Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pool/SNOW-937189 busy sessions in pool (3/4) #818

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Pool/SNOW-937189 busy sessions in pool (3/4) #818

merged 3 commits into from
Nov 28, 2023

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

Connection Pool v2:

  • introduction of a counter of busy sessions created by Pool Manager
  • pool size counts both: Idle and Busy sessions

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner November 21, 2023 14:35
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bf7a13e) 81.58% compared to head (6dced6c) 81.55%.

Files Patch % Lines
Snowflake.Data/Core/Session/SessionPool.cs 96.87% 1 Missing ⚠️
Additional details and impacted files 
@@                         Coverage Diff                          @@
##           pool/SNOW-860872-connection-pool     #818      +/-   ##
====================================================================
- Coverage                             81.58%   81.55%   -0.04%     
====================================================================
  Files                                    91       93       +2     
  Lines                                  9313     9334      +21     
  Branches                                857      858       +1     
====================================================================
+ Hits                                   7598     7612      +14     
- Misses                                 1474     1483       +9     
+ Partials                                241      239       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sfc-gh-mhofman
sfc-gh-mhofman requested changes Nov 24, 2023
View reviewed changes
Snowflake.Data/Core/Session/ICounter.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/UnitTests/Session/NonNegativeCounterTest.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/FixedZeroCounter.cs Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Show resolved Hide resolved
Snowflake.Data.Tests/UnitTests/ConnectionPoolManagerTest.cs Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/ConnectionSinglePoolCacheIT.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Outdated Show resolved Hide resolved
@sfc-gh-knozderko sfc-gh-knozderko merged commit 56f0b81 into pool/SNOW-860872-connection-pool Nov 28, 2023
19 of 20 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the pool/SNOW-937189_busy_sessions_in_pool branch November 28, 2023 09:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mhofman sfc-gh-mhofman sfc-gh-mhofman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-knozderko @sfc-gh-mhofman